From tradke at aei.mpg.de Mon Jul 3 12:30:54 2006 From: tradke at aei.mpg.de (Thomas Radke) Date: Mon, 03 Jul 2006 19:30:54 +0200 Subject: [Patches] [Developers] more efficient synchronisation of groups In-Reply-To: References: <44A546CC.4030309@aei.mpg.de> Message-ID: <44A9544E.3020600@aei.mpg.de> Tom Goodale wrote: > Looks good. Just a few things to make the transition easier and safer: > > * This will eventually completely replace the current overloading of > CCTK_SyncGroup, so the default CCTK_SyncGroup should now call > CCTK_SyncGroupByDirI. > > * Overloading CCTK_SyncGroup should now produce a warning message saying > this is deprecated and they should overload CCTK_SyncGroupByDirI. > > * The default for CCTK_SyncGroupByDirI should check for a NULL directions > array and then call CCTK_SyncGroup in a loop if CCTK_SyncGroup has been > overloaded. (This code will disappear once CCTK_SyncGroup is no longer > overloadable.) > > The intent of this is that drivers should only need to overload one of the > functions, we preserve the current behaviour for drivers which have not > been updated yet, and that we will be able to remove the overloading of > CCTK_SyncGroup once we are sure all drivers have converted to the new > mechanism. Okay, here is a revised version of the patches, implementing Tom's suggestions from above plus a change in the prototypes for CCTK_SyncGroupsI() and CCTK_SyncGroupsByDirI() where the array arguments are now passed as 'CCTK_INT*' (rather than 'int*'). -- Cheers, Thomas. -------------- next part -------------- A non-text attachment was scrubbed... Name: SyncGroupsByDirI-Carpet.patch Type: text/x-patch Size: 3503 bytes Desc: not available Url : http://www.cactuscode.org/pipermail/patches/attachments/20060703/3738eb65/attachment.bin -------------- next part -------------- A non-text attachment was scrubbed... Name: SyncGroupsByDirI-Flesh.patch Type: text/x-patch Size: 18260 bytes Desc: not available Url : http://www.cactuscode.org/pipermail/patches/attachments/20060703/3738eb65/attachment-0001.bin -------------- next part -------------- A non-text attachment was scrubbed... Name: SyncGroupsByDirI-PUGH.patch Type: text/x-patch Size: 4139 bytes Desc: not available Url : http://www.cactuscode.org/pipermail/patches/attachments/20060703/3738eb65/attachment-0002.bin From tradke at aei.mpg.de Thu Jul 6 04:16:26 2006 From: tradke at aei.mpg.de (Thomas Radke) Date: Thu, 06 Jul 2006 11:16:26 +0200 Subject: [Patches] change the default parameter checking level from "normal" to "strict" In-Reply-To: <44A40444.2080206@aei.mpg.de> References: <449FC6A6.2040006@aei.mpg.de> <44A40444.2080206@aei.mpg.de> Message-ID: <44ACD4EA.7050605@aei.mpg.de> Thomas Radke wrote: > Hi, > > in today's Cactus call my patch to conclude the discussion thread > http://www.cactuscode.org/old/pipermail/users/2006-June/001864.html was > finally approved. In future, any errors in the parameter file will by > default cause Cactus to stop at startup. If you don't want such a strict > checking, you should use the commandline option '--parameter-level > '. > > I will wait to commit this patch until next Thursday (6 July) to give > people time to fix their "relaxed" Cactus parameter files or add one of > the relaxed parameter checking options above in their Cactus wrapper > scripts. You can easily check if your parameter files need fixing: run > them with the option '--parameter-level strict' and see if Cactus chokes > while reading in the parameter file. Time is up, patch has been APPLIED. -- Cheers, Thomas. From tradke at aei.mpg.de Thu Jul 6 13:21:37 2006 From: tradke at aei.mpg.de (Thomas Radke) Date: Thu, 06 Jul 2006 20:21:37 +0200 Subject: [Patches] [Developers] more efficient synchronisation of groups In-Reply-To: <44A92DC6.6010401@aei.mpg.de> References: <44A546CC.4030309@aei.mpg.de> <44A901A3.1020700@aei.mpg.de> <78D2B6E7-2726-4D53-8F17-C2794AB7FBF7@cct.lsu.edu> <44A92DC6.6010401@aei.mpg.de> Message-ID: <44AD54B1.8000708@aei.mpg.de> APPLIED. -- Cheers, Thomas. From frank.loeffler at aei.mpg.de Wed Jul 26 03:33:08 2006 From: frank.loeffler at aei.mpg.de (Frank Loeffler) Date: Wed, 26 Jul 2006 10:33:08 +0200 Subject: [Patches] Make ADMConstraints GF public Message-ID: <44C728C4.6070008@aei.mpg.de> Hi, this patch makes the GFs of CactusEinstein/ADMConstraints public. The reason is that this way other thorns can use the values already computed here for their own purposes by inheritage. One example of such a thorn is ADMDevelopment/MaskedADMConstraints, which requires this patch to work. Another possibility to access these GF would be to get their pointer by variable name. However, I would consider inheritage cleaner. I also cannot see a reason why these variables should stay private. Frank -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch_ADMConstraints Url: http://www.cactuscode.org/pipermail/patches/attachments/20060726/e5abab94/attachment.pl