[Patches] Make ADMConstraints GF public

[Steve White]

Hi,

I tried running the testsuites before and after applying the patch.
I compiled in all the distro thorns I could (-= SDF, PETC, LAPACK etc)

Find attached the results.

With and without Franks patch 34 tests and 34 fail.

Unfortunately the results are slightly different.
On the other hand, there are just more error messages
before the patch than after.

This test seems to fail in somewhat different ways in the two cases
	test_ADM_4

I'm kind of in a rush, so it's hard for me to judge. 

What's the call?

On 26.07.06, Frank Loeffler wrote:
> Hi,
> 
> this patch makes the GFs of CactusEinstein/ADMConstraints public.
> 
> The reason is that this way other thorns can use the values already 
> computed here for their own purposes by inheritage. One example of such 
> a thorn is ADMDevelopment/MaskedADMConstraints, which requires this 
> patch to work.
> Another possibility to access these GF would be to get their pointer by 
> variable name. However, I would consider inheritage cleaner. I also 
> cannot see a reason why these variables should stay private.
> 
> Frank

> Index: interface.ccl
> ===================================================================
> RCS file: /cactusdevcvs/CactusEinstein/ADMConstraints/interface.ccl,v
> retrieving revision 1.18
> diff -u -r1.18 interface.ccl
> --- interface.ccl	14 Feb 2005 09:50:26 -0000	1.18
> +++ interface.ccl	26 Jul 2006 08:27:08 -0000
> @@ -20,7 +20,7 @@
>  USES FUNCTION Boundary_SelectVarForBC
>  USES FUNCTION Boundary_SelectGroupForBC
>  
> -private:
> +public:
>  
>  real hamiltonian type=GF tags='tensortypealias="Scalar"'
>  {

> _______________________________________________
> Patches mailing list
> Patches at cactuscode.org
> http://www.cactuscode.org/mailman/listinfo/patches


-- 
Steve White : Programmer
Max-Planck-Institut für Gravitationsphysik      Albert-Einstein-Institut
Am Mühlenberg 1, D-14476 Golm, Germany                  +49-331-567-7625
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ts.gz
Type: application/x-gzip
Size: 9354 bytes
Desc: not available
Url : http://www.cactuscode.org/pipermail/patches/attachments/20060831/e2536ca7/attachment.gz 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ts-patched.gz
Type: application/x-gzip
Size: 8106 bytes
Desc: not available
Url : http://www.cactuscode.org/pipermail/patches/attachments/20060831/e2536ca7/attachment-0001.gz