[Developers] Making WaveToy use InitBase

[Thomas Radke]

Erik Schnetter wrote:
> The IDScalarWave thorns currently initialise exactly two time levels.   
> This is inconvenient for mesh refinement: If three time levels are  
> needed, then Carpet has to perform an additional initialisation step  
> and cannot rely on the analytic solution for initial data.   
> Furthermore, if this is not done, the third time level remains  
> uninitialised, leading to problems that are very difficult to detect,  
> since people typically don't output past time levels.
> 
> I suggest to make IDScalarWave use the InitBase infrastructure to  
> detect this problem.  In particular, if InitBase specifies that only a  
> single time level is to be initialised, IDScalarWave should do so, and  
> if all time levels should be initialised, IDScalarWave should either  
> also do so, or abort with an error message during parameter checking.

Hi Erik,

the attached patch for CactusWave/IDScalarWaveC checks how many 
timelevels are currently active, and initialises them. This should make 
it work again with Carpet.
Note that InitBase is not (explicitely) used for the check; do you think 
it should be ?

If the patch is good I'll apply it also to the other IDScalarWave thorns 
in CactusWave.

-- 
Cheers, Thomas.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: IDScalarWaveC.patch
Type: text/x-patch
Size: 5062 bytes
Desc: not available
Url : http://www.cactuscode.org/pipermail/developers/attachments/20080310/611d060a/attachment-0001.bin