[Developers] Fwd: [CactusMaint] CactusUtils/2079: Patch for thorn TimerReport: Output timer reports to a file instead of to stdout

[Thomas Radke]

Erik Schnetter wrote:
> The message below proposes a patch to the flesh.  Thomas, Jonathan,  
> Tom, could you have a look?

With this new flesh function CCTK_SchedulePrintTimesToFile() your patch 
to thorn TimerReport becomes partially obsolete, I presume. I have added 
a new patch (attachement 2 on 
http://www.cactuscode.org/cactus_cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=cactus&pr=2079) 
which should replace the old one. Two comments to this one:

  * In schedule.ccl the TimerReport_Output routine at TERMINATE must be
    scheduled BEFORE DriverTerminate, otherwise you will run into a
    'null communicator' MPI error when calling 'CCTK_MyProc(cctkGH)'.
    This slight rescheduling of routines implies that we can't measure
    the exact time spent in the TERMINATE bin but the inaccuracy should
    be negligible.

  * Declaring a large local array 'char filename [10000];' in Output.c
    is potentially dangerous and probably overkill anyway. I reduced
    its size to 200 characters which should suffice.

I have tested your flesh patch with the most recent TimerReport patch, 
and they work fine for me.

-- 
Cheers, Thomas.