[Developers] Change to Cactus/lib/make/make.configuration

Erik Schnetter schnetter at cct.lsu.edu
Wed Aug 22 10:47:50 CDT 2007


Thorn Formaline creates tarballs for all thorn source code.  Some  
architectures, noticeably AIX, have rather strict limits on the  
length of a command line, and Formaline can fail there if many thorns  
are used.

It is very difficult to work around this problem, since only make  
knows the list of all thorns, and it cannot pass it to any shell  
function.  This makes it also impossible to write this make variable  
into a file.

One solution is to create a set of make rules, one rule per thorn,  
and then call make recursively.  This happens in Formaline in  
make.configuration.deps, which is called from Cactus/lib/make/ 
make.configuration.

In order to make this work, the following lines need to be added to  
Cactus/lib/make/make.configuration:

ifeq ($(suffix $(strip $(MAKECMDGOALS))), .objectlist)
-include $(CONFIG)/make.thornlist
endif

These lines are very similar to the existing lines:

ifeq ($(strip $(MAKECMDGOALS)),)
-include $(CONFIG)/make.thornlist
endif

ifeq ($(strip $(MAKECMDGOALS)), utils)
-include $(CONFIG)/make.thornlist
endif

ifeq ($(strip $(MAKECMDGOALS)), build)
-include $(CONFIG)/make.thornlist
endif

This introduces a special case to Cactus/lib/make/make.configuration,  
which treats all make goals ending in ".objectlist" specially.  At  
the moment, all goals ending in "-utils" and "-build" are treated  
specially.

Is it okay to apply this patch?

-erik

-- 
Erik Schnetter <schnetter at cct.lsu.edu>

My email is as private as my paper mail.  I therefore support encrypting
and signing email messages.  Get my PGP key from www.keyserver.net.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
Url : http://www.cactuscode.org/pipermail/developers/attachments/20070822/32da1a93/attachment-0001.bin 


More information about the Developers mailing list